variorum
variorum copied to clipboard
Fix type in variable declarations
In many places in Variorum, I see declarations made as unsigned var, without the datatype being explicitly specified.
This defaults to unsigned int , and is functionally correct (unsigned is a datatype), but is not considered good engineering practice, esp because we're not consistent with its usage. As part of cleanup, I'd like to change these from unsigned to unsigned int.
See here as some examples: https://github.com/LLNL/variorum/blob/f7bb01ff83b8bc4a0f97adfee4568b70f6df064b/src/variorum/config_architecture.h#L321-L324 https://github.com/LLNL/variorum/blob/f7bb01ff83b8bc4a0f97adfee4568b70f6df064b/src/variorum/Intel/counters_features.c#L539-L541