serac icon indicating copy to clipboard operation
serac copied to clipboard
verified publisher icon LLNL

Use correct primal values in the sensitivity calls

Open jamiebramwell opened this issue 2 years ago • 1 comments

As written, the sensitivity calculation calls in the HeatTransfer and SolidMechanics modules will not use the correct primal field values (e.g. temperature) during the backward adjoint pass. See https://github.com/LLNL/serac/blob/a2d7924235565ceccb2a7b341951680aa3afb679/src/serac/physics/heat_transfer.hpp#L921-L927 .

jamiebramwell avatar Oct 19 '23 19:10 jamiebramwell

We should check that the correct time is used as well. Ideally, we should write tests that fail before patching the bugs.

btalamini avatar Oct 24 '23 18:10 btalamini

Yeah, fixed as far as current testing can confirm.

tupek2 avatar Aug 23 '24 14:08 tupek2