metall icon indicating copy to clipboard operation
metall copied to clipboard

Suggestion: Make fallback_allocator::stateful_allocatorator_available() public

Open bigerl opened this issue 1 year ago • 2 comments

https://github.com/LLNL/metall/blob/1f6c027680ea89bf92bd9a5255e006c044aa078f/include/metall/container/fallback_allocator.hpp#L217-L219

We use the fallback_allocator in an algorithm that behaves differently based on weather the stateful allocator is used or not. ATM, we just re-implement the private_stateful_allocatorator_available() in our code.

I would suggest to make a public stateful_allocatorator_available(). Shouldn't hurt because the interfaces to calculate the result are public anyway and might come in handy for others.

PS: Is allocatorator a pun or a typo?

bigerl avatar Aug 07 '24 08:08 bigerl

That's a good idea. I'll implement a public functionstateful_allocatorator_available() .

Oh, allocatorator is a typo😂. I'll also fix that.

KIwabuchi avatar Aug 11 '24 21:08 KIwabuchi

BTW, would you like to have a web meeting to discuss Metall sometime this Month? I'm happy to take questions and/or new feature requests.

KIwabuchi avatar Aug 11 '24 21:08 KIwabuchi