merlin icon indicating copy to clipboard operation
merlin copied to clipboard

Add support for non-merlin blocks in specification file

Open ryannova opened this issue 3 years ago • 7 comments

Updated #367.

Updated: Updated Changelog

ryannova avatar Sep 23 '22 02:09 ryannova

These PRs need some doc updates.

koning avatar Sep 27 '22 16:09 koning

I'm not too familiar with the merlin workflows yet, so I'm not sure what is the purpose for the addition of non-merlin "user" block. If you could let me know what to add for docs I can include it in the merlin_specification.rst and merlin_variables.rst where it is documented.

ryannova avatar Sep 27 '22 16:09 ryannova

We can workshop it in the comments, maybe @jimagaffney can give us an example.

koning avatar Sep 27 '22 17:09 koning

The user block allows other variables / yaml syntax in the workflow file to be propagated through to the workflow (including in the .parital.yaml and .expanded.yaml). This gives the user increased flexibility in how they write their files.

For instance, a user can use anchors etc. to define configurations and then reference them later

lucpeterson avatar Sep 27 '22 18:09 lucpeterson

That's great. Is there an sample or example I can use? Since in the current documentation an example was given for each block.

ryannova avatar Sep 27 '22 18:09 ryannova

That's great. Is there an sample or example I can use? Since in the current documentation an example was given for each block.

@jimagaffney can you cook up an example?

lucpeterson avatar Sep 27 '22 18:09 lucpeterson

That's great. Is there an sample or example I can use? Since in the current documentation an example was given for each block.

@jimagaffney can you cook up an example?

Jim says he can cook up an example at the end of next week

lucpeterson avatar Sep 28 '22 18:09 lucpeterson

What's the status of this and the other PR? #378 Are we good?

lucpeterson avatar Oct 28 '22 17:10 lucpeterson

I think we should be good for this one and the other PR. #378 I don't have anything else I need to change for either. If you can take a final look, to check we should be good to merge them in.

ryannova avatar Oct 28 '22 17:10 ryannova