Add reset() method to SYCL reduction types

Open rhornung67 opened this issue 4 years ago • 2 comments

These appear to be missing and are preventing us from enabling SYCL reduction tests in our CI. For example,

https://github.com/LLNL/RAJA/blob/develop/test/functional/forall/reduce-basic/tests/test-forall-basic-ReduceMin.hpp#L63

@homerdin do you have time to add these?

Jan 20 '22 17:01 rhornung67

@rhornung67 Yeah I will get them added and push a branch.

Jan 20 '22 18:01 homerdin

Thank you. We appreciate it.

You can add to this branch https://github.com/LLNL/RAJA/pull/1196 if you want since this is where I am enabling the sycl tests and you can see if it's working in our ci.

I turned it off in one chunk of tests that uses reset. You can enable it by uncommenting these lines: https://github.com/LLNL/RAJA/blob/add-sycl-tests/test/functional/forall/reduce-basic/CMakeLists.txt#L30

Jan 20 '22 18:01 rhornung67