activity-browser icon indicating copy to clipboard operation
activity-browser copied to clipboard

Biosphere3 database readonly checkbox option should be disabled

Open marc-vdm opened this issue 3 years ago • 7 comments

The Biosphere3 database has the read only checkbox like any other database in AB, however, it doesn't make sense to have this as a user can't actually change anything. image

We can just disable the checkbox like for edit activity (when a database is read-only). image

We can just check if name == 'Biosphere3' and then something similar to what we do for the edit activity option: https://github.com/LCA-ActivityBrowser/activity-browser/blob/b2d2f5884204eb59a1f3016b1dc41136c9d1f47c/activity_browser/layouts/tabs/activity.py#L280

marc-vdm avatar Nov 21 '22 15:11 marc-vdm

@marc-vdm : you are obviously right that the check-box is not necessary at all for the biosphere3 database... the question is if we should add code for a "special handling" of this or not. Perhaps we can wait to see what happens on the development of biosphere databases for non-ecoinvent data etc. (e.g. to see if in the future we will have several biosphere databases

bsteubing avatar Jan 27 '23 08:01 bsteubing

@bsteubing , Need some help from you, can you please share your email id please.

arpitgreenstitch avatar Jun 14 '23 10:06 arpitgreenstitch

Hi @arpitgreenstitch,

if you like we could meet? Is there a specific issue that you need some help on? You can email me at [email protected]

Zoophobus avatar Jun 14 '23 10:06 Zoophobus

Would like to understand a bit more about the LCA and the Activity Browser you have created.

Regards Arpit

On Wed, 14 Jun 2023 at 16:20, Jonathan Kidner @.***> wrote:

Hi @arpitgreenstitch https://github.com/arpitgreenstitch,

if you like we could meet? Is there a specific issue that you need some help on?

— Reply to this email directly, view it on GitHub https://github.com/LCA-ActivityBrowser/activity-browser/issues/881#issuecomment-1590957450, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7PE3IRYFZ2AT2Q4FBCLBULXLGJPPANCNFSM6AAAAAASGZBJDQ . You are receiving this because you were mentioned.Message ID: @.***>

arpitgreenstitch avatar Jun 14 '23 10:06 arpitgreenstitch

Feel free to ask any questions, if you like we could arrange a short teams meeting?

Zoophobus avatar Jun 14 '23 11:06 Zoophobus

Sure, let's connect sometime when you are free.

On Wed, 14 Jun 2023 at 16:41, Jonathan Kidner @.***> wrote:

Feel free to ask any questions, if you like we could arrange a short teams meeting?

— Reply to this email directly, view it on GitHub https://github.com/LCA-ActivityBrowser/activity-browser/issues/881#issuecomment-1590987359, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7PE3IQMOTKYT77JRRND5VLXLGL5HANCNFSM6AAAAAASGZBJDQ . You are receiving this because you were mentioned.Message ID: @.***>

arpitgreenstitch avatar Jun 14 '23 11:06 arpitgreenstitch

Hi @arpitgreenstitch,

you can make an appointment for this week if you like?

KR, Jon

Zoophobus avatar Jun 14 '23 14:06 Zoophobus