activity-browser icon indicating copy to clipboard operation
activity-browser copied to clipboard

Run tests for python 3.10

Open haasad opened this issue 3 years ago • 1 comments

haasad avatar Feb 18 '22 15:02 haasad

Coverage Status

Coverage remained the same at 54.445% when pulling b6a3d4fb4dce5f736c9b43ca24c33eeb659992e5 on haasad:test-py310 into 0d4a531a472779371debd7af54f683d745ae2936 on LCA-ActivityBrowser:master.

coveralls avatar Feb 18 '22 15:02 coveralls

@haasad, the logs of the tests have been deleted so I can't check this (or re-run the tests?). Do you recall the reason why AB didn't work with 3.10 and what we should do to fix it?

marc-vdm avatar Sep 22 '23 13:09 marc-vdm

I've added a commit to trigger the pipeline again. IIRC there were some segfaults on linux. I'm on holidays currently, won't be at a computer until next week

haasad avatar Sep 22 '23 18:09 haasad

Thanks! Enjoy your holidays!

edit: I suggest we review this again somewhere in end October/start November as 3.12 is scheduled to release early October. Then we can see if we can just transfer to 3.11 and 3.12 and skip 3.10 as it does seem to be still broken.

marc-vdm avatar Sep 22 '23 20:09 marc-vdm

Note, when moving to newer version, we should update the pint fix (#982)

marc-vdm avatar Oct 12 '23 12:10 marc-vdm

@haasad can I close this and #1124 or would you still like to try and figure out what the issue was?

marc-vdm avatar Dec 20 '23 13:12 marc-vdm

Fine to close, can always reopen if needed

haasad avatar Dec 20 '23 13:12 haasad