Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Use API to populate text_labels in frontend

Open melvinebenezer opened this issue 3 years ago • 1 comments

Modify textFlagLabels in FlaggableElement.tsx to be coherent with the backend using the API (yet to be created)

https://github.com/LAION-AI/Open-Assistant/blob/69bc799cd9bdb80bcaa8388368b75551d573eac0/oasst-shared/oasst_shared/schemas/protocol.py#L263

melvinebenezer avatar Jan 07 '23 16:01 melvinebenezer

decision is that @andreaskoepf will add an API endpoint to query valid values + descriptions ... This is a cleaner approach

melvinebenezer avatar Jan 07 '23 16:01 melvinebenezer

can we close this?

https://github.com/LAION-AI/Open-Assistant/blob/5d1b03b02dce0f87d9ae6f9322c249be5905dfd6/website/src/components/FlaggableElement.tsx#L51

AbdBarho avatar Jan 13 '23 06:01 AbdBarho

I believe so. We're fetching the labels from the backend endpoint. @melvinebenezer can you verify?

fozziethebeat avatar Jan 13 '23 06:01 fozziethebeat

Yes, this is fetched from the endpoint. Can be closed

melvinebenezer avatar Jan 17 '23 04:01 melvinebenezer