Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

README Fixing

Open EditaNEmilis opened this issue 2 years ago • 12 comments

Tiny or small fix with the typo and others. But only two files (or more), can be minor changes tho..

EditaNEmilis avatar Jun 15 '23 22:06 EditaNEmilis

Gerai then..

EditaNEmilis avatar Jun 16 '23 08:06 EditaNEmilis

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Jun 20 '23 17:06 github-actions[bot]

Commited and fixed.

EditaNEmilis avatar Jun 20 '23 19:06 EditaNEmilis

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Jun 20 '23 19:06 github-actions[bot]

@EditaNEmilis could you please fix pre-commit & the solve the conflict? thx

andreaskoepf avatar Jul 19 '23 22:07 andreaskoepf

I'm trying to.. But it's not working.

EditaNEmilis avatar Jul 21 '23 12:07 EditaNEmilis

https://github.com/LAION-AI/Open-Assistant/actions/runs/5326388567/job/14415197147?pr=3481

data/datasets/poetry_instruction/README.md

it either likes or does not like the spaces here:

 - INSTRUCTION (string): The user asks for a poem (from a variety of premade
-prompts) with topics (tags). If the given poem has no tags, the user asks for a
-poem on it's own.
+  prompts) with topics (tags). If the given poem has no tags, the user asks for
+  a poem on it's own.
 
-- RESPONSE (string): The assistant replies with the poem and title (from a variety
-of premade prompts).
+- RESPONSE (string): The assistant replies with the poem and title (from a
+  variety of premade prompts).
 
 - SOURCE (string): The source is PoetryFoundation.org and the poet's name.
 
 - METADATA (JSON String): {"author": "author of the original poem", "title":
-"title of the poem", "tags": "tags from poetry foundation."}
+  "title of the poem", "tags": "tags from poetry foundation."}

so i think if you remove those spaces at start of line it might fix it

If gets too messy then i'd just undo your changes in this file and make it so its same as whats currently in master. That would also be one solution.

andrewm4894 avatar Jul 21 '23 13:07 andrewm4894

i fixed the conflict

andrewm4894 avatar Jul 21 '23 13:07 andrewm4894

ill try fix pre-commit on this end

andrewm4894 avatar Jul 21 '23 13:07 andrewm4894

Alright. Thanks.

EditaNEmilis avatar Jul 21 '23 13:07 EditaNEmilis

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Jul 21 '23 13:07 github-actions[bot]

(not able to fix on my end since is in a fork)

@EditaNEmilis can you run pre-commit run --all?

and then commit the changes it makes

andrewm4894 avatar Jul 21 '23 14:07 andrewm4894