Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Focus on input on edit chat title clicked

Open bishowX opened this issue 2 years ago • 6 comments

This PR brings following changes:

  1. When clicking on edit chat title button the input field will now be on focus.
  2. Clicking on edit prompt button will set the focus on chat box

Fixes #2519

bishowX avatar Apr 20 '23 16:04 bishowX

I'm open to discussions around is this a good user experience or we should do it differetly

bishowX avatar Apr 20 '23 16:04 bishowX

Thank you, also there is more input is the edit prompt input (the one when you click edit icon), can you add that too?

Can you show me where the prompt edit button is please. I couldn't find that.

bishowX avatar Apr 20 '23 16:04 bishowX

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Apr 20 '23 16:04 github-actions[bot]

Can you show me where the prompt edit button is please. I couldn't find that.

https://github.com/LAION-AI/Open-Assistant/blob/99301ccd3e670c447e5b7faa474ae1a156cf1981/website/src/components/Chat/ChatMessageEntry.tsx#L118

notmd avatar Apr 20 '23 16:04 notmd

Also can you upload a screen record here?

notmd avatar Apr 20 '23 17:04 notmd

Also can you upload a screen record here?

Just pushed the changes to focus prompt input. which screen record do you want?

bishowX avatar Apr 20 '23 17:04 bishowX