Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Updates based on #1610. Resolves #1286

Open BrianArbuckle opened this issue 2 years ago • 2 comments

@dctanner noticed and error, which I fixed on the Hugging Face Dataset as well as replaced the loading_script.py with a notebook importer loading_notebook.ipynb.

BrianArbuckle avatar Mar 01 '23 21:03 BrianArbuckle

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Mar 01 '23 21:03 github-actions[bot]

How come we are replacing a loading script with a notebook here? My understanding was that notebooks are for code which generates the data originally and uploads it to HF in the OA-compatible format, and then there should be no need for a specific script/notebook to load the dataset and instead it can just be added here.

olliestanley avatar Mar 01 '23 21:03 olliestanley