Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Allow to enable/disable email signin via env variable

Open notmd opened this issue 3 years ago • 5 comments

close #911

notmd avatar Feb 01 '23 17:02 notmd

@yk I guess NEXT_PUBLIC_ENABLE_EMAIL_SIGNIN also needs to be added to the github-worklfow deploy-to-node.yaml & ansible ?

andreaskoepf avatar Feb 01 '23 18:02 andreaskoepf

do we need to add the variable to https://github.com/LAION-AI/Open-Assistant/blob/main/ansible/deploy-to-node.yaml ?

AbdBarho avatar Feb 01 '23 20:02 AbdBarho

So do I need to update other config? Also, should I rename it NEXT_PUBLIC_DISABLE_EMAIL_SIGNIN to allow incremental migration?

notmd avatar Feb 02 '23 09:02 notmd

do we need to add the variable to https://github.com/LAION-AI/Open-Assistant/blob/main/ansible/deploy-to-node.yaml ?

Yes and in https://github.com/LAION-AI/Open-Assistant/blob/main/.github/workflows/deploy-to-node.yaml when we want to control the variable via github. As far as I understand the check for the variable defaults to false .. i.e. the feature is disabled if the variable is missing. This means we need to make sure it is properly set for staging and production .. otherwise email-signup will not work.

andreaskoepf avatar Feb 02 '23 09:02 andreaskoepf

Actually wait, I'm going to un-approve this until I go through the sign up process and set the env variables. Merging this too quickly could break things.

fozziethebeat avatar Feb 02 '23 12:02 fozziethebeat