Autometa icon indicating copy to clipboard operation
Autometa copied to clipboard

Fix Issue#349

Open Sidduppal opened this issue 1 year ago • 2 comments

median_completeness is being set to NA when filtered_df is empty. Which is causing the TypeError: boolean value of NA is ambiguous error reported in issue#349. Setting median completeness to 0 when it's NA seems to resolve this without causing any more bugs.

Sidduppal avatar Feb 10 '24 18:02 Sidduppal

@Sidduppal or @jason-c-kwan can you create a fresh conda env using this commit? It's taking an incredibly long time to solve on my computer

chasemc avatar Feb 20 '24 22:02 chasemc

@chasemc It took about 7 min for the environment to solve and create using mamba. However, the following tests are failing as mentioned before:


FAILED 😰  tests/unit_tests/test_recursive_dbscan.py::test_taxon_guided_binning - autometa.common.exceptions.BinningError: Failed to recover any clusters from dataset
FAILED 😰  tests/unit_tests/test_recursive_dbscan.py::test_get_clusters[hdbscan] - TypeError: boolean value of NA is ambiguous
FAILED 😰  tests/unit_tests/test_recursive_dbscan.py::test_recursive_dbscan_main - SystemExit: 204

@samche42 mentioned that she got pretty reasonable MAGs after using the fix.

Sidduppal avatar Feb 20 '24 23:02 Sidduppal