operating icon indicating copy to clipboard operation
operating copied to clipboard

feat(rollout): automatically set partition if podTemplate of collaset controlled by rollout changes

Open zoumo opened this issue 1 year ago • 1 comments

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • [ ] N
  • [ ] Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [ ] N
  • [ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Benchmark (add benchmark stats below)
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

zoumo avatar Jul 12 '24 06:07 zoumo

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.59%. Comparing base (dab15ec) to head (2df33eb).

Files Patch % Lines
...rver/generic/collaset/collaset_mutating_handler.go 0.00% 22 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   65.76%   65.59%   -0.17%     
==========================================
  Files          73       73              
  Lines        5158     5180      +22     
==========================================
+ Hits         3392     3398       +6     
- Misses       1439     1457      +18     
+ Partials      327      325       -2     
Flag Coverage Δ
unittests 65.59% <0.00%> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 12 '24 06:07 codecov[bot]