operating icon indicating copy to clipboard operation
operating copied to clipboard

Support "Container Recreate" and "Pod Replace" in Batch

Open ColdsteelRail opened this issue 1 year ago • 1 comments

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • [ ] N
  • [x] Y #189

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [ ] N
  • [ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • [ ] Unit test
  • [ ] Integration test
  • [ ] Benchmark (add benchmark stats below)
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ColdsteelRail avatar May 11 '24 08:05 ColdsteelRail

Codecov Report

Attention: Patch coverage is 74.15186% with 160 lines in your changes are missing coverage. Please review.

Project coverage is 67.23%. Comparing base (7f1e94d) to head (4fd7ba7). Report is 2 commits behind head on main.

:exclamation: Current head 4fd7ba7 differs from pull request most recent head bb0b952

Please upload reports for the commit bb0b952 to get more accurate results.

Files Patch % Lines
...ontrollers/operationjob/operationjob_controller.go 62.43% 51 Missing and 17 partials :warning:
pkg/controllers/operationjob/recreate.go 77.67% 32 Missing and 16 partials :warning:
pkg/controllers/operationjob/replace.go 77.96% 16 Missing and 10 partials :warning:
pkg/controllers/operationjob/event_handler.go 80.43% 7 Missing and 2 partials :warning:
...g/controllers/operationjob/operationjob_manager.go 82.69% 7 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   66.38%   67.23%   +0.84%     
==========================================
  Files          74       81       +7     
  Lines        5156     5775     +619     
==========================================
+ Hits         3423     3883     +460     
- Misses       1412     1525     +113     
- Partials      321      367      +46     
Flag Coverage Δ
unittests 67.23% <74.15%> (+0.84%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 08:05 codecov[bot]