kusion icon indicating copy to clipboard operation
kusion copied to clipboard

feat: support kusion state remote storage

Open markliby opened this issue 3 years ago • 1 comments

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • [ ] N
  • [x] Y

re #114

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/backend pkg/engine/states/local

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • [ ] Affects user behaviors
  • [ ] Contains syntax changes
  • [ ] Contains variable changes
  • [ ] Contains experimental features
  • [ ] Performance regression: Consumes more CPU
  • [ ] Performance regression: Consumes more Memory
  • [x] Other support diff backend store state, more detail docs/backend.md

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [x] N
  • [ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • [x] Unit test
  • [ ] Integration test
  • [ ] Benchmark (add benchmark stats below)
  • [ ] Manual test (add detailed scripts or steps below)
  • [ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

markliby avatar Aug 11 '22 06:08 markliby

Pull Request Test Coverage Report for Build 2865846997

  • 70 of 107 (65.42%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 74.347%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 3 5 60.0%
pkg/kusionctl/cmd/destroy/options.go 8 10 80.0%
pkg/engine/states/local/backend.go 15 20 75.0%
pkg/engine/backend/backend.go 42 70 60.0%
<!-- Total: 70 107
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
<!-- Total: 3
Totals Coverage Status
Change from base Build 2864919723: 0.004%
Covered Lines: 4324
Relevant Lines: 5816

💛 - Coveralls

coveralls avatar Aug 11 '22 06:08 coveralls

I have a small tip, you can add language in code block in backend.md, like below: before:

backend:
  storageType: local
  config:
    path: kusion_state.json

after

backend:
  storageType: local
  config:
    path: kusion_state.json

howieyuen avatar Aug 17 '22 09:08 howieyuen