Sims4Tools icon indicating copy to clipboard operation
Sims4Tools copied to clipboard

Buzz-pbox/patch-1

Open pboxx opened this issue 10 years ago • 4 comments

  • Incorporated Inge's latest wrappers (refactored to e.g. meet naming conventions).
  • Replaced ushort tag values and hard-coded enums with a parsing functionality of the EAxian XML that contains the catalog categories and tags. Tags are deserialized into a custom class which is used instead of the ushort/values values. Also included is a custom editor to edit the value in the grid.
  • Edited OBJD to correctly read/display EmotionEnvironmentTag indexes
  • Added XML resource with tag information to project.

pboxx avatar Aug 28 '15 22:08 pboxx

Why to change the entire implementation?

Kuree avatar Aug 29 '15 18:08 Kuree

Not sure which implementation you mean; flags or wrappers. Inge's wrappers are more complete regarding the semantic information like "PlacementFlags" vs. Unknown or something. pbox and I refactored them to be a little more in line with the usual C# conventions, though. The tag thing is because the previous implementation was a PITA (I was told) to use, because you had a dropdown with 1677 elements to choose from. It was also hard-coded while now you just need to drop the new resource into the S4pe folder and have the most current reincarnation of the EAxian tags.

BTW: There was an issue with the output directory of the new project in the first version of this request. I just fixed it and pbox updated the pull request. The project references of the solution seem to be a mess, though, with hard references to the compiled assemblies instead of the projects. That's why the output directory of each project even matters. I may have a look at that at some point.

BrutalBuzzler avatar Aug 29 '15 19:08 BrutalBuzzler

The pull-request changed the way that most catalog resources behave. The current implementation has self-clone feature.

Kuree avatar Aug 31 '15 01:08 Kuree

Changing the way that the catalog resources behave is exactly the point of this.

Regarding the clone feature, do you mean the Alex Burtsev stuff that is used in COBJ? If so: what is the actual advantage of that? It would probably not be a big deal to move that over to Inge’s version, I just don’t know of anything that doesn’t work in hers.

pboxx avatar Sep 06 '15 19:09 pboxx