Krypton
Krypton copied to clipboard
Players changing view distance breaks SortedArraySet removeIf
Description
With the new chunk loading system, attempting to re-propagate a player with a different view distance can sometimes result in NullPointerExceptions from removeIf.
Do note, however, that this is not as simple as just properly null checking, as that will result in strange behaviour.
Steps to reproduce
Note: currently not reproducible, as per-player view distances are currently disabled due to this issue.
- Join the server with a set view distance
- Decrease the view distance
- Get kicked for internal exception
Expected behaviour
The removeIf operation removes all values matching the predicate, appropriately dealing with null values when they arise.
Details
- Server version: Krypton 0.33
- Java version: 16
Other information
N/A
This will get fixed when I drop the very broken ticket-based chunk propagation system.