ReMarkable icon indicating copy to clipboard operation
ReMarkable copied to clipboard

Broken in php7

Open antoine9298 opened this issue 10 years ago • 8 comments

PHP7 disable the /e operator for preg_replace -> need to be replaced by “preg_replace_callback()”.

otherwise, remarkable() simply return nothing in php7.

antoine9298 avatar Jan 13 '16 16:01 antoine9298

Thank you very much for the bug report! (and the one before) :) I don't know when I'll be able to get to this as my son requires 24/7 attention, but any update to ReMarkable will provide a fix to this.

Kroc avatar Jan 13 '16 17:01 Kroc

I tried to solve it, but I’m far to be good at dealing with regexp. The simple fix will probably be less readeable since it will split the replace in 2.

PHP7 is coming… now in arch and other bleeding edge release.

Remarkable is still one of the most elegant and readable markdown-like. Keep going :-)

antoine9298 avatar Jan 17 '16 22:01 antoine9298

I'm just starting to get back into PHP development and will be updating my various PHP projects to PHP 7, starting with "DOMTemplate". When I get to ReMarkable I will aim to rewrite it specifically for PHP 7 as it could really do with some simplification :)

Kroc avatar Jan 18 '16 17:01 Kroc

agree, do you plan to do it one a separate branch ?

antoine9298 avatar Feb 10 '16 16:02 antoine9298

@Kroc also, your website seems down, also checked using tor exit nodes in Sweden, Norway, Netherlands, Slovakia (…?)

antoine9298 avatar Feb 10 '16 16:02 antoine9298

It's working here at this time, so could have been down temporarily then; I'm on a cheap shared host, I don't expect much :)

When I get to ReMarkable, it might be a new project entirely as the code and project layout will be fundamentally different - see https://github.com/Kroc/css2xpath for example

Kroc avatar Feb 11 '16 12:02 Kroc

Hey, css2xpath looks very interesting ! I always found xpath unwritable (given up after about half a day)

Still, remarkable is very interesting, very readable, but with a lot of possibilities (still miss “footnote” feature, but that's not critical, and possible to do anyway)

antoine9298 avatar Feb 16 '16 18:02 antoine9298

ReMarkable will definitely get footnotes and the like. Since you are a user, please file any requests you have or mail me and I'll consider them all.

Kroc avatar Feb 16 '16 18:02 Kroc