ImageViewer
ImageViewer copied to clipboard
Change public to open.
I'm using Carthage, so the ImageViewer code is inside a framework. In ItemBaseController.swift many things are implicitly or explicitly only public, so I can't override or access them.
Is there any reason you wish to prevent overriding properties and methods in this class?
Specifically, I am overriding or accessing fetchImage(), scrollView, itemView, activityIndicatorView. In order to do so, I need to change these from public to open.
I can submit a pull request, but I wanted to get your thoughts first.
I don't see a problem why not. Please send a PR.