dataframe icon indicating copy to clipboard operation
dataframe copied to clipboard

Arrow writing

Open Kopilov opened this issue 3 years ago • 1 comments

#162 duplicate

Kopilov avatar Sep 17 '22 17:09 Kopilov

Hello @koperagen,

right now i seem to lack general understanding, so i'll review it again a bit later.

You cal look similar module in krangl. And ask me about anything if you want.

What do you think about making possible warnings a sealed class with overloaded toString for default behaviour? So that you can access actual exception in conversion or DataColumn and KType, etc.

Sorry, I still do not have enough time to elaborate this. Working on another part of the customer's project currently…

Kopilov avatar Sep 20 '22 12:09 Kopilov

possible warnings a sealed class

Started working on this

Kopilov avatar Nov 16 '22 14:11 Kopilov

@koperagen @Jolanrensen @nikitinas Hi, this branch is upgraded. Evaluate please :)

Kopilov avatar Nov 29 '22 18:11 Kopilov

@Kopilov updated the comments with my thoughts :) the rest looks good!

Jolanrensen avatar Dec 01 '22 14:12 Jolanrensen

I'm gonna change ArrowWriter.Companion.Mode -> ArrowWriter.Mode. It is less typing, cleaner, and Companion is always avoided in Kotlin unless explicitly needed.

Jolanrensen avatar Dec 19 '22 12:12 Jolanrensen

Hello @Jolanrensen, OK, thanks

Kopilov avatar Dec 19 '22 12:12 Kopilov