github-integration-plugin icon indicating copy to clipboard operation
github-integration-plugin copied to clipboard

Add support for teams in User Restriction

Open sebastienvas opened this issue 8 years ago • 3 comments

Currently I am using the restriction for all users in a given org which works well. However we are getting some PRs from people outside the org so I created a team of white listed people however I don't know how to make the plugin understand this.

Another simpler way would also be:

I also enabled the "comment matched to pattern" trigger, it would be easier to check if the user making the comment matches the user restrictions regardless of the author of the PR, that way I would not have to create a white listed group.

sebastienvas avatar Mar 21 '17 17:03 sebastienvas

Any update on this ?

sebastienvas avatar Apr 01 '17 05:04 sebastienvas

were you able to add adhoc user in the user restriction whitelist and make it work? I doesn't work for me. https://github.com/KostyaSha/github-integration-plugin/issues/233

kknd22 avatar Sep 06 '17 14:09 kknd22

Sorry, somehow loosing issues/notifications. It's a complex question about permissions where i don't see the best solution. Initially userRestriction was bundled into trigger as security API and container org/user patterns. Event checks (rules) for triggering should call them to check whether it allowed to do something from user. But event itself could do checks and it unclear now what happened. I can add options if we will find some design solution...

KostyaSha avatar Sep 06 '17 14:09 KostyaSha