zmanim
zmanim copied to clipboard
KosherJava
KosherJava Zmanim API / Library
This change is not needed right now, but it seems like IntelliJ says that the Unicode escape characters can be replaced with other characters. I do not believe this will...
I know the getTzaisGeonim13AndAHalfMinutesZmanis method has a bad history. However, I just wanted to point out that it is technically missing from the API, and there is a zman that...
The method getMisheyakir66MinutesZmanis is a method I use myself so I know the source, but I do not know the source for the getMisheyakir60MinutesZmanis method. However, I know for sure...
These methods are important to me personally and I would appreciate it if you would add them to the JewishCalendar class. Me and @pinnymz worked on these methods together and...
https://github.com/KosherJava/zmanim/blob/d24323b295779dd4922dccf418afc54e420e592a/src/main/java/com/kosherjava/zmanim/util/Zman.java#L238 The javadoc for it says > As of release JDK 5, this class has been supplemented with an equivalent class designed for use by a single thread, StringBuilder. The...
I would like some input on the most ergonomic API surface for identifying a given zman. I am developing [KosherKotlin](https://github.com/Sternbach-Software/KosherKotlin) in tandem with [BeautifulZmanim](https://github.com/Sternbach-Software/BeautifulZmanim), and the need came up to...
Why does rosh hashana(h) have two different spellings? (Seems reminiscent of #213) Same for Suk(k)ah, Kesub(v)os, Ta(')anis, Megil(l)ah, Kidushin, Horayos, Bava Kama, Makos, Nidah. https://github.com/KosherJava/zmanim/blob/bca6ddb85542683f229d905636a06fbfc66fbe03/src/main/java/com/kosherjava/zmanim/hebrewcalendar/Daf.java#L39 https://github.com/KosherJava/zmanim/blob/bca6ddb85542683f229d905636a06fbfc66fbe03/src/main/java/com/kosherjava/zmanim/hebrewcalendar/Daf.java#L70 And while I am...
Shouldn't this be `>=` instead of `>`? If 30 minutes is equal to the second zman, return 30 minutes (or the other zman, depending on how you look at it)....
Replace `implementation group: 'com.kosherjava', name: 'zmanim', version: '2.4.0'` with `implementation 'com.kosherjava:zmanim:2.4.0`