zmanim icon indicating copy to clipboard operation
zmanim copied to clipboard

Inconsistancies between erev pesach related zmanim

Open dickermoshe opened this issue 2 months ago • 1 comments

This is commented out for some reason

https://github.com/KosherJava/zmanim/blob/3ebea96eb57e6618f729ab9ce9eae9cc6e3b8e35/src/main/java/com/kosherjava/zmanim/ComplexZmanimCalendar.java#L3787-L3796

IMHO, we should keep calendar and zmanim calculations separate, but I think we gotta be consistent.

dickermoshe avatar Nov 10 '25 03:11 dickermoshe

@dickermoshe , My plan was to add this to 3.0 since it is a breaking change (for whatever reason, someone may rely on it for non-erev Pesach). As far as separation, we already have Molad calculations using the calendar code, so I see no issue expanding it.

KosherJava avatar Nov 11 '25 17:11 KosherJava