fix yerushalmi yomi class

Open Elyahu41 opened this issue 3 years ago • 1 comments

So... a little background as to why I want to suggest this fix. I was using the Yerushalmi Calculator in my zmanim app and I noticed that it returned masechta nidda and null for the daf on tisha b'av. Same is true for Yom kippur.

No where in the javadoc does it mention this, only in the code. I had to figure this out the hard way.

In this PR, I suggest a few changes to the javadoc to make it more clear to people to check for edge cases/nulls.

And I don't know why the author decided to return a new Daf(39, 0) instead of just null. That object will return null on the getDaf() method and it is not clear why in the Daf class.

Let me know what you think about this issue.

Aug 15 '22 18:08 Elyahu41

P.S. sorry for the blank spaces. I copied over the whole class a few times while figuring out how to commit a proper PR.

Aug 15 '22 18:08 Elyahu41