insomnia
insomnia copied to clipboard
modal class->fc
Highlights
- modal.show() had args but they didn't do anything, however modal classes using
<Modalhave a show function with args 38 of the file changes are introducing the type ModalHandle to the 38 files that use the modal ref.
Uncertainties
- there's an onHide function on the Modal class that doesn't appear to do anything - removed
- theres a dom walker that searches up 5 parent elements to find the close button attribute
- there a force refresh that could probably be removed with some experimentation
- theres a an one-off option isOpen that could be removed if request switcher modal used isModalVisible rather than this one-off
EDIT: onHide may still have a purpose. Considering back out of this change.