LuaFormatter icon indicating copy to clipboard operation
LuaFormatter copied to clipboard

Increase coverage of tests

Open tammela opened this issue 5 years ago • 6 comments

The test suite is not covering some branches.

We shall increase our tests based on the reports from codecov.

tammela avatar Feb 25 '20 09:02 tammela

I want to work on this issue. Can u guide me ?

karanankit01 avatar Feb 26 '20 19:02 karanankit01

We use codecov as an interface for the coverage reports.

In codecov we can see that there are some files with paths that are not explored by our test cases. We ideally should create test cases that hit them.

tammela avatar Feb 27 '20 10:02 tammela

Is that missed lines in the report you talking about? Marked with red ?

karanankit01 avatar Feb 27 '20 10:02 karanankit01

Yes

On Thu, 27 Feb 2020, 11:42 Ankit Karan, [email protected] wrote:

Is that missed lines in the report you talking about? Marked with red ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Koihik/LuaFormatter/issues/94?email_source=notifications&email_token=ACECBM7C4OZ4EPXZWOXFBHTRE6KIFA5CNFSM4K3DNY2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEND3NRI#issuecomment-591902405, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACECBM4U26I73775Y7F5J23RE6KIFANCNFSM4K3DNY2A .

tammela avatar Feb 27 '20 12:02 tammela

I have added some test cases but can't able to check the changes by codecov coverage . Please let me know how to check the changes locally.

karanankit01 avatar Feb 28 '20 19:02 karanankit01

Ideally you can get the reports from locally from lcov.

Check this workflow on how we do it in our CI. https://github.com/Koihik/LuaFormatter/blob/master/.github/workflows/coverage.yml

The part that interests you are the lcov installation and how to run lcov to extract the report.

tammela avatar Feb 29 '20 13:02 tammela