PIPKit icon indicating copy to clipboard operation
PIPKit copied to clipboard
verified publisher icon Kofktu

Support SceneDelegate based application

Open yasheedv opened this issue 3 years ago • 4 comments

I have created a sample application with iOS 13 target. It's using SceneDelegate. PIPKit.show(with: PIPViewController()) not showing the PIPViewController

yasheedv avatar Apr 27 '22 07:04 yasheedv

It's working if I change PIPKitWindow allocation like below under PIPKit class line number 73

let newWindow: PIPKitWindow if let currentWindowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene { newWindow = PIPKitWindow(windowScene: currentWindowScene) } else { newWindow = PIPKitWindow() }

yasheedv avatar Apr 27 '22 08:04 yasheedv

Can I request a PR?

Kofktu avatar May 03 '22 10:05 Kofktu

@yasheedv Could you test it with that feature/issue-34-support_scenedelegate branch?

Kofktu avatar Aug 15 '22 14:08 Kofktu

I tested it today and it is working very good. Please PR

Pobe16 avatar Oct 19 '22 15:10 Pobe16