zigbee2mqtt icon indicating copy to clipboard operation
zigbee2mqtt copied to clipboard

chore: release dev

Open Koenkk opened this issue 1 year ago • 14 comments

:robot: I have created a release beep boop

1.37.1

1.37.1 (2024-05-08)

Bug Fixes

  • Add Helm chart (#21852) (b2e8b3e)
  • Add settings for finer control over debug log level (#22426) (eb49f52)
  • Fix MQTT ECONNREFUSED error https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/issues/605 (a0c9a17)
  • ignore: update dependencies (#22456) (b754b9d)
  • ignore: update zigbee-herdsman to 0.46.0 (#22380) (55b5f91)
  • ignore: update zigbee-herdsman to 0.46.1 (#22439) (329d832)
  • ignore: update zigbee-herdsman to 0.46.2 (#22470) (e4c9bac)
  • ignore: update zigbee-herdsman to 0.46.3 (#22471) (316654b)
  • ignore: update zigbee-herdsman to 0.46.4 (#22501) (e44608a)
  • ignore: update zigbee-herdsman to 0.46.5 (#22552) (6bcb4b6)
  • ignore: update zigbee-herdsman-converters to 19.33.0 (#22381) (907591c)
  • ignore: update zigbee-herdsman-converters to 19.35.0 (#22442) (beedfae)
  • ignore: update zigbee-herdsman-converters to 19.36.0 (#22472) (358e2ee)
  • ignore: update zigbee-herdsman-converters to 19.36.1 (#22503) (3544d51)
  • ignore: update zigbee-herdsman-converters to 19.37.0 (#22531) (6b886f6)
  • ignore: update zigbee-herdsman-converters to 19.37.1 (#22549) (cc9a95c)
  • ignore: update zigbee2mqtt-frontend to 0.6.166 (#22410) (5899436)
  • ignore: update zigbee2mqtt-frontend to 0.6.167 (#22419) (23e97d0)
1.37.1

1.37.1 (2024-05-08)

Bug Fixes


This PR was generated with Release Please. See documentation.

Koenkk avatar May 06 '24 19:05 Koenkk

@jlpedrosa looks good now, many thanks!

Koenkk avatar May 06 '24 19:05 Koenkk

@jlpedrosa looks good now, many thanks!

At your service, feel free to ping me if this is causing issues. I will test this as soon as the release is created.

jlpedrosa avatar May 06 '24 19:05 jlpedrosa

@jlpedrosa yes, will ping you with the next release, since we are planning a hotfix release it should come soon.

Koenkk avatar May 06 '24 20:05 Koenkk

I am not sure if it was the force push the reason why the CI is stuck, in actions all seems correct....

jlpedrosa avatar May 06 '24 22:05 jlpedrosa

Since the CI generates another commit, not sure if the force push is confusion to the CI system? maybe instead of force pushing, maybe an empty commit?

git commit --allow-empty -m "Empty-Commit"

jlpedrosa avatar May 07 '24 19:05 jlpedrosa

@Koenkk I see one step is failing from the previous steps of the CI. image Let me have a look

jlpedrosa avatar May 07 '24 19:05 jlpedrosa

Humm, the output is empty, there's not a single log line. It seems

node scripts/generateChangelog.js $MASTER_Z2M_VERSION $MASTER_ZHC_VERSION $MASTER_ZH_VERSION $MASTER_FRONTEND_VERSION >> ../changelog.md

is having issues, I don't have a clue of Javascript, but I don't think it's using any file that has been modified by the helm chart. I have tried to reproduce it locally with the two branches checked out, but it works on my pc. Not sure what I can do to help.

jlpedrosa avatar May 07 '24 19:05 jlpedrosa

@jlpedrosa the branch name changed due to https://github.com/jlpedrosa/zigbee2mqtt/commit/04e0e3ff36c910c2c9e2567887f39176adf81613, fixed it in https://github.com/Koenkk/zigbee2mqtt/commit/834626d2e9a2851462599db3c285617fe3e739b1

Koenkk avatar May 08 '24 20:05 Koenkk

Yeah, that makes sense, but I don't see the CI trigger for the next commit... it's strange: image

I am not sure if it's the force push...

jlpedrosa avatar May 08 '24 20:05 jlpedrosa

I see the CI is configured for push, not sure why the other commit is not triggering it. I don't know if it's the loop protection from GH. https://github.com/Koenkk/zigbee2mqtt/blob/ee5cf5a901ea6fb3426bd534d4f3d44a8ce5c28f/.github/workflows/ci.yml#L3

jlpedrosa avatar May 08 '24 20:05 jlpedrosa

GH doesn't run pipelines for commits done via Github actions, adding the token should fix it (https://github.com/Koenkk/zigbee2mqtt/commit/aecdfe638bf9dedb525020e7aac97ed20241c770)

Koenkk avatar May 08 '24 20:05 Koenkk

GH doesn't run pipelines for commits done via Github actions, adding the token should fix it (aecdfe6)

Yeah, that decision was apparently intentional to prevent loops. that is what I meant.

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

jlpedrosa avatar May 08 '24 21:05 jlpedrosa

Works now! 🥳

Koenkk avatar May 08 '24 21:05 Koenkk

:partying_face: !!! image

Thanks man!

jlpedrosa avatar May 08 '24 21:05 jlpedrosa