Kinc icon indicating copy to clipboard operation
Kinc copied to clipboard
verified publisher icon Kode

[featurerequest] some graphic options and fixes

Open malublu opened this issue 8 years ago • 9 comments

currently i look myself to implement this feautures in kore (but i don't know if i can it):

  • change vsync option at runtime (*0)
  • fix vsync for some graphic targets
    • d3d9
    • d3d12
    • Metal?
    • Vulkan?
  • change antialiasingSamples option at runtime
  • fix antialiasingSamples for some graphic targets
    • Vulkan?
    • Metal?
    • d3d12
  • fix mouse lock/hide for some system target (*1)
    • linux
    • mac
    • more ...?
  • requestBorderless (*1) (fullscreen not supported for some targets)
  • exitBorderless (*1) (fullscreen not supported for some targets)
  • requestMostTop (*1)
  • exitMostTop (*1)
  • resize/set position for the window (*1) (changeResolution needed?)
  • replace changeResolution with resize/set postion?
  • remove fullscreen or we need it? (can be replaced via mix of resize/set pos + requtestBorderless + requestMostTop)

do we need more?

(*0) nearly finished for opengl and (*1) + android/ios, als no tests for ios (*1) nearly finished for win/linux/mac, not tested for linux/mac and i can't make a test for mac. And i have also no idea if the code can work for the mac.

malublu avatar Dec 13 '17 01:12 malublu

@malublu you can just send PR, and we'll help you test

RblSb avatar Dec 30 '17 12:12 RblSb

What does fix vsync mean?

RobDangerous avatar Jan 21 '18 17:01 RobDangerous

Not all targets implement it. But currently, i have currently no time to work on it, because my "place of work" say no! If i have private more time, i try to work on the code.

I also can send you my current work, if you want.

malublu avatar Jan 22 '18 13:01 malublu

What's the status on this? Did @malublu ever share his WIP? I can't see any branches on his fork of Kore which would tie up with the description above.

grayhaze avatar Jul 03 '18 15:07 grayhaze

Don't think so. Working on window things myself right this minute.

RobDangerous avatar Jul 04 '18 22:07 RobDangerous

@grayhaze it was a local copy. Currently i have no time to work on it. (Because my work) I think it will take several months until I have time again. But some other peoples work also on it. https://github.com/armory3d/armory/issues/224 If I find the code again, I can gladly upload it the next few days (weeks).

malublu avatar Jul 05 '18 07:07 malublu

All of this is now implemented in Kore for Windows via Direct3D 11 and OpenGL. Not yet fully exposed in Kha. Sorry @malublu, had to get cracking on it.

RobDangerous avatar Jul 08 '18 01:07 RobDangerous

No Problem. @RobDangerous thanks for it 👍

malublu avatar Jul 10 '18 08:07 malublu

In theory the new Window API is now fully operational in Windows and mostly operational in macOS. Feel free to do some testing.

RobDangerous avatar Jul 14 '18 16:07 RobDangerous