Support of PHP versions?
I see this library still supports PHP 7.2, which is End of Life (EOL) for a while. Even 7.3 is EOL as of today.
What's the policy about PHP support? The only supported versions are 7.4, 8.0 and 8.1
In my opinion libraries should drop support of PHP versions that are end of life, because it makes contributing to this library much easier.
I agree, but I think it doesn't make much sense to drop unsupported version in the bundle if they're still supported in the main library.
Do you mind opening a PR to drop PHP 7.3 from KnpMenu? 7.2 was already dropped.
See https://github.com/KnpLabs/KnpMenu/issues/357
This Issue could be closed as done. Or meanwhile it could be raised to PHP 8.0 ?
This Issue could be closed as done. Or meanwhile it could be raised to PHP 8.0 ?
It should be raised to PHP 8.0 indeed. After merging that, we can close this issue (until the next end of line, at least)
This could be closed as completed.