KnpMenuBundle icon indicating copy to clipboard operation
KnpMenuBundle copied to clipboard

Support of PHP versions?

Open stephanvierkant opened this issue 4 years ago • 2 comments

I see this library still supports PHP 7.2, which is End of Life (EOL) for a while. Even 7.3 is EOL as of today.

What's the policy about PHP support? The only supported versions are 7.4, 8.0 and 8.1

In my opinion libraries should drop support of PHP versions that are end of life, because it makes contributing to this library much easier.

stephanvierkant avatar Dec 06 '21 18:12 stephanvierkant

I agree, but I think it doesn't make much sense to drop unsupported version in the bundle if they're still supported in the main library.

Do you mind opening a PR to drop PHP 7.3 from KnpMenu? 7.2 was already dropped.

garak avatar Dec 06 '21 18:12 garak

See https://github.com/KnpLabs/KnpMenu/issues/357

stephanvierkant avatar Dec 06 '21 21:12 stephanvierkant

This Issue could be closed as done. Or meanwhile it could be raised to PHP 8.0 ?

Chris53897 avatar May 12 '23 14:05 Chris53897

This Issue could be closed as done. Or meanwhile it could be raised to PHP 8.0 ?

It should be raised to PHP 8.0 indeed. After merging that, we can close this issue (until the next end of line, at least)

garak avatar May 12 '23 16:05 garak

This could be closed as completed.

Chris53897 avatar Aug 25 '23 08:08 Chris53897