glance icon indicating copy to clipboard operation
glance copied to clipboard

Inline build for ParaView scene export

Open Lgt2x opened this issue 1 year ago • 4 comments

Add a build:inline npm script that builds Glance with all assets inlined, so that the bundled HTML file is standalone and can be used for the ParaView scene export to VTKJS. This mimics the build behavior we had in Glance 4.17 before the Webpack 5 migration.

cc @mwestphal

Lgt2x avatar Aug 01 '24 08:08 Lgt2x

@floryst @bourdaisj

Lgt2x avatar Aug 02 '24 09:08 Lgt2x

bundle is also used after build:release in the Github action script https://github.com/Kitware/glance/blob/master/.github/workflows/publish.yml#L29

Lgt2x avatar Aug 02 '24 14:08 Lgt2x

I suppose that does add a ParaViewGlance.html to the output bundle, but since it is currently it's kind of broken anyways I'm okay with removing that step in the publish workflow.

floryst avatar Aug 02 '24 15:08 floryst

build:inline and bundle merged

Lgt2x avatar Aug 05 '24 07:08 Lgt2x

LGTM. Thanks!

floryst avatar Aug 05 '24 15:08 floryst

:tada: This PR is included in version 4.25.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 07 '24 14:08 github-actions[bot]