SlicerSALT icon indicating copy to clipboard operation
SlicerSALT copied to clipboard

S-rep hypothesis testing work

Open bpaniagua opened this issue 3 years ago • 6 comments

  1. Generate a module that does batch fits of s-reps
  2. Read the documentation sent by Mohsen incl. paper describing the method and R-codebase
  3. Generate a module for hypothesis testing in S-reps

bpaniagua avatar Dec 14 '22 16:12 bpaniagua

The new pipeline creator is a good candidate for this. The (unmerged) new pipeline creator plus the work in this commit can make a module that does initial-fit + refinement. The batch processing part of the new pipeline infrastructure has not been started however.

Connor-Bowley avatar Mar 09 '23 20:03 Connor-Bowley

  1. Generate a module that does batch fits of s-reps

@allemangD @HarryDC

Going to use this issue to expand on this part. Batch fitting needs to run two modules:

  1. SRepCreator: Given an input surface and some parameters generates an initial s-rep
  2. SRepRefiner: Given an input surface and the initial s-rep generated by 1), improves the fit

The initial stitching of those two together should be in the commit that Connor linked above, the missing piece is just the batch processing.

vicory avatar Jun 08 '23 16:06 vicory

Yea I looked at the two pipelines, i think those are good to go, I have the creator in a state too where it can potentially store multiple output paramters/nodes. And we are ready to create a pipeline from the two parts.

I can put up a SlicerSalt branch that has the connors branch in SRep and my pipelines working branch tied together, i'll set up a combined pipeline so that all the parameters are exposed in the Creator/Refiner pipeline, you should then be able to create a .csv with all the input nodes and input parameters and run that through the Creator/Refiner

HarryDC avatar Jun 16 '23 16:06 HarryDC

@vicory Where should the created combined module live ? Checked into SREP as a module or as something under SlicerSALT ?

HarryDC avatar Jun 21 '23 12:06 HarryDC

Hi Harry, The new module should live under s-reps.

bpaniagua avatar Jun 21 '23 12:06 bpaniagua

Quick update, it took a bit of hand editing (the annotations that limit the inputs and confer the defaults aren't copied by the pipeline creator) but this is the Combined Module.

image

The list of parameters is long as I exposed all the parameters of both the generation and the refinement pipelines

I'll push updates Slicer/SRep/Pipenline branches so you can test this

HarryDC avatar Jun 21 '23 19:06 HarryDC

https://github.com/Kitware/SlicerSALT/commit/9b5ad911cef11e91dba13104da0ae2d4ffe09e8e

bpaniagua avatar Oct 07 '24 11:10 bpaniagua