LookingGlassVTKModule icon indicating copy to clipboard operation
LookingGlassVTKModule copied to clipboard

COMP: Streamline client project integration by explicitly including "vector"

Open jcfr opened this issue 3 years ago • 4 comments

This commit fixes regression introduced in b99fa7324 (Add several functions to the render window) allowing client project to successfully build without having to include "vector" header.

jcfr avatar Nov 01 '22 04:11 jcfr

Re-running failed test (Linux wheels).

aylward avatar Nov 01 '22 17:11 aylward

Error is the following:

        CMake Error at /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
          Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Development.Module)
          (found suitable version "3.7.15", minimum required is "3.7")
        Call Stack (most recent call first):
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPython/Support.cmake:3203 (find_package_handle_standard_args)
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPython3.cmake:490 (include)
          /vtk-wheel-sdk/vtk-9.2.2.data/headers/cmake/VTK-vtk-module-find-packages.cmake:444 (find_package)
          /vtk-wheel-sdk/vtk-9.2.2.data/headers/cmake/vtk-config.cmake:152 (include)
          CMakeLists.txt:29 (find_package)
        
        
        -- Configuring incomplete, errors occurred!
        See also "/project/_skbuild/linux-x86_64-3.7/cmake-build/CMakeFiles/CMakeOutput.log".
        See also "/project/_skbuild/linux-x86_64-3.7/cmake-build/CMakeFiles/CMakeError.log".
        /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/setuptools_scm/git.py:135: UserWarning: "/project" is shallow and may cause errors
          warnings.warn(f'"{wd.path}" is shallow and may cause errors')
        Traceback (most recent call last):
          File "/tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/skbuild/setuptools_wrap.py", line 637, in setup
            languages=cmake_languages,
          File "/tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/skbuild/cmaker.py", line 334, in configure
            "An error occurred while configuring with CMake.\n"

Source: https://github.com/Kitware/LookingGlassVTKModule/actions/runs/3366862318/jobs/5594079792

jcfr avatar Nov 01 '22 17:11 jcfr

Since I am working on enabling VTK wheel build for another project, I will investigate and report back.

jcfr avatar Nov 01 '22 17:11 jcfr

I re-ran the workflow on master and encountered the same error, so it must be due to some change that's happened recently in the CI build process (a dependency, a change to the docker image, etc.).

psavery avatar Nov 02 '22 13:11 psavery