SwiftyRequest icon indicating copy to clipboard operation
SwiftyRequest copied to clipboard

Certificate Pinning Verification

Open ShihabMehboob opened this issue 8 years ago • 7 comments

Verify server certificates the user is connecting to. In relation to this issue: https://github.com/IBM-Swift/SwiftyRequest/issues/19

ShihabMehboob avatar Feb 20 '18 12:02 ShihabMehboob

Codecov Report

Merging #20 into master will decrease coverage by 0.46%. The diff coverage is 84.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   53.12%   52.65%   -0.47%     
==========================================
  Files           9        9              
  Lines         800      809       +9     
==========================================
+ Hits          425      426       +1     
- Misses        375      383       +8
Flag Coverage Δ
#SwiftyRequest 52.65% <84.52%> (-0.47%) :arrow_down:
Impacted Files Coverage Δ
Sources/SwiftyRequest/RestRequest.swift 59.17% <84.52%> (-0.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82d49d1...9fc6da3. Read the comment docs.

codecov-io avatar Feb 21 '18 15:02 codecov-io

Hi there, any updates on this PR?

neurosaurus avatar Jul 05 '18 22:07 neurosaurus

@ShihabMehboob ?

ianpartridge avatar Jul 06 '18 08:07 ianpartridge

@ianpartridge This PR is ready for review/merging (two Travis tests appear to fail but all pass locally so could just be an anomaly).

ShihabMehboob avatar Jul 09 '18 08:07 ShihabMehboob

testGetSelfSignedCert() exists, which passes in containsSelfSignedCert: true to invoke the urlSession delegate with the URLAuthenticationChallenge and server trust.

ShihabMehboob avatar Jul 09 '18 14:07 ShihabMehboob

Does it cover the certificate pinning though?

ianpartridge avatar Jul 09 '18 15:07 ianpartridge

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: ShihabMehboob
:x: ianpartridge
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 27 '20 02:09 CLAassistant