BlueCryptor icon indicating copy to clipboard operation
BlueCryptor copied to clipboard

Request: bcrypt implementation

Open TaborKelly opened this issue 6 years ago • 5 comments

A ready to go bcrypt implementation would be a very nice thing to have.

TaborKelly avatar May 31 '19 21:05 TaborKelly

Agreed!

ianpartridge avatar May 31 '19 21:05 ianpartridge

Note that CommonCrypto doesn't seem to have a bcrypt implementation, which may make this impossible as we don't provide crypto in this library - just APIs on top.

ianpartridge avatar Jun 05 '19 11:06 ianpartridge

That’s correct. That’s why I didn’t do an implementation before. Somebody was working on an implementation that could be integrated awhile back but never submitted a PR for it. I’ll take a look and see what it would take. There’s bound to be an open source implementation around that's of proper quality that it could be modified and integrated into the library. I found one earlier but it was way too bloated and other commitments sidetracked me and I never got back to it. Any suggestions of a good, lean implementation that might used? Even one in C would be fine if self contained, I could port it over to Swift rather quickly.

billabt avatar Jun 05 '19 12:06 billabt

I concur. I erroneously though that CommonCrypto exposed EksBlowfishSetup(), but it doesn't as far as I can tell. I threw this together over the weekend and you are welcome to use it, but I'm not sure if it meets your IP requirements or not: https://github.com/TaborKelly/Bcrypt

TaborKelly avatar Jun 05 '19 15:06 TaborKelly

Thank you for linking but I'm afraid we couldn't take a pure Swift implementation. This project does not embed crypto itself, so we couldn't integrate C code either. What we could do is have API which delegated to OpenSSL on Linux, and was non-functional on Darwin.

ianpartridge avatar Jun 05 '19 16:06 ianpartridge