AudioLoader icon indicating copy to clipboard operation
AudioLoader copied to clipboard

Invalid hash arguments to download_url

Open marvinborner opened this issue 2 years ago • 1 comments

Since the import uses a different function for torch 2.0, the arguments changed a bit. The function doesn't accept the checksums as before. I just removed it in this PR for now; this shouldn't be merged directly.

A better solution would probably be to use the new checksum arguments (SHA256) and remove support for torch <2 completely. But that's your decision I guess.

Edit: Some other arguments also changed.. Idk

marvinborner avatar Aug 18 '23 10:08 marvinborner

Thank you for reporting this issue. An alternative solution might be porting the old download_url function from torchaudio to here. I actually ported it to utils.py already.

https://github.com/KinWaiCheuk/AudioLoader/blob/37c1d86af3e006ca759ed175039295d23bb35740/AudioLoader/utils.py#L108-L115

And we can import it like this https://github.com/KinWaiCheuk/AudioLoader/blob/37c1d86af3e006ca759ed175039295d23bb35740/AudioLoader/music/mss/musdbhq.py#L24-L27

KinWaiCheuk avatar Aug 18 '23 11:08 KinWaiCheuk