OpenXR-Docs icon indicating copy to clipboard operation
OpenXR-Docs copied to clipboard

Alias used incorrectly on `SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT` in registry file

Open MarkY-LunarG opened this issue 1 year ago • 2 comments

I'm writing codegen using the xr.xml and I believe the alias for SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT in the file is defined incorrectly.

Currently it is defined with the alias in the KHR indicating that the correct label to use (the alias) is the MND version when I believe it should be the other way around:

Currently

KHR:

    <extension name="XR_KHR_swapchain_usage_input_attachment_bit" number="166" type="instance" supported="openxr">
...
            <enum extends="XrSwapchainUsageFlagBits"    \ 
                         name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR"   \
                         alias="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                         comment="Specifies that the image may: be used as a input attachment."
              />
...
    </extension>

Monado:

    <extension name="XR_MND_swapchain_usage_input_attachment_bit" number="97" type="instance" supported="openxr" promotedto="XR_KHR_swapchain_usage_input_attachment_bit">
...
            <enum bitpos="7" extends="XrSwapchainUsageFlagBits" \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>

Correct?

KHR:

    <extension name="XR_KHR_swapchain_usage_input_attachment_bit" number="166" type="instance" supported="openxr">
...
            <enum extends="XrSwapchainUsageFlagBits"    \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>

Monado:

    <extension name="XR_MND_swapchain_usage_input_attachment_bit" number="97" type="instance" supported="openxr" promotedto="XR_KHR_swapchain_usage_input_attachment_bit">
...
            <enum bitpos="7" extends="XrSwapchainUsageFlagBits" \
                          name="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_MND" \
                          alias="XR_SWAPCHAIN_USAGE_INPUT_ATTACHMENT_BIT_KHR" \
                          comment="Specifies that the image may: be used as a input attachment."/>
...
    </extension>

MarkY-LunarG avatar Mar 04 '24 21:03 MarkY-LunarG

ah, yes, that's a subtle one but I think you are right. Presumably I didn't fully understand the aliases when we put that in.

rpavlik avatar Mar 07 '24 22:03 rpavlik

An issue (number 2228) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2228 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

rpavlik-bot avatar Mar 07 '24 23:03 rpavlik-bot