OpenCOLLADA icon indicating copy to clipboard operation
OpenCOLLADA copied to clipboard
verified publisher icon KhronosGroup

COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h: Include pcre.h

Open devurandom opened this issue 7 years ago • 4 comments

This fixes a compilation error with libpcre-8.42:

error: conflicting declaration 'typedef struct real_pcre8_or_16 pcre'

Also remove inclusion of pcre.h from files already including COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h

Closes: #547 Closes: #570 Depends-On: #581

devurandom avatar Jul 12 '18 05:07 devurandom

FAILURE: exercise-opencollada-pull-request build #143

  • COLLADA-MAX-PC-PULL-REQUEST build #447 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #441 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #430 with result SUCCESS. Artifacts: Maya 2015 Maya 2016 Maya 2017
  • openCOLLADA-mac-pull-request build #440 with result FAILURE.
  • openCOLLADA-pc-pull-request build #436 with result FAILURE.
  • openCOLLADA-ubuntu-pull-request build #329 with result SUCCESS. Artifacts: OpenCOLLADA Ubuntu

Pull Requests:

  • PR https://github.com/KhronosGroup/OpenCOLLADA/pull/582: COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h: Include pcre.h OpenCOLLADA

Fl4reBot avatar Jul 13 '18 22:07 Fl4reBot

broken jenkins computer (HW failure)..

RemiArnaud avatar Jul 17 '18 17:07 RemiArnaud

I relaunched the build, but this is not a Jenkins issue only. those changes break the build everywhere

for example:

on windows: e:\git\workspace\collada-max-pc-pull-request\colladabaseutils\include\COLLADABUPcreCompiledPattern.h(16): fatal error C1083: Cannot open include file: 'pcre.h': No such file or directory [e:\git\workspace\COLLADA-MAX-PC-PULL-REQUEST\COLLADAFramework\scripts\COLLADAFramework.vcxproj]

on mac: openCOLLADA-mac-pull-request/COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h:16:10: fatal error: 'pcre.h' file not found #include <pcre.h>

RemiArnaud avatar Jul 17 '18 17:07 RemiArnaud

FAILURE: exercise-opencollada-pull-request build #150

  • COLLADA-MAX-PC-PULL-REQUEST build #453 with result FAILURE.
  • COLLADA-MAYA-PC-PULL-REQUEST build #448 with result FAILURE.
  • Maya-2015_2017-mac-pull-request build #437 with result SUCCESS. Artifacts: Maya 2015 Maya 2016 Maya 2017
  • openCOLLADA-mac-pull-request build #447 with result FAILURE.
  • openCOLLADA-pc-pull-request build #442 with result FAILURE.
  • openCOLLADA-ubuntu-pull-request build #336 with result SUCCESS. Artifacts: OpenCOLLADA Ubuntu

Pull Requests:

  • PR https://github.com/KhronosGroup/OpenCOLLADA/pull/582: COLLADABaseUtils/include/COLLADABUPcreCompiledPattern.h: Include pcre.h OpenCOLLADA

Fl4reBot avatar Jul 17 '18 18:07 Fl4reBot