OpenCOLLADA icon indicating copy to clipboard operation
OpenCOLLADA copied to clipboard

Fix line endings

Open devurandom opened this issue 7 years ago • 4 comments

CRLF and LF were mixed in lots of files, confusing tools like patch.

devurandom avatar Jul 12 '18 05:07 devurandom

FAILURE: exercise-opencollada-pull-request build #142

Pull Requests:

  • PR https://github.com/KhronosGroup/OpenCOLLADA/pull/581: Fix line endings OpenCOLLADA

Fl4reBot avatar Jul 13 '18 22:07 Fl4reBot

I cannot access build #440 -- it says I am lacking the "read" permissions. I would like to take a look at the logs, to figure out what my patch broke.

Also, who is @fl4re? That group does not appear to be affiliated with Khronos, so why is Khronos using their Jenkins?

devurandom avatar Jul 14 '18 04:07 devurandom

who is @fl4re? fl4re IP was acquired by Starbreeze a while back

why is Khronos using their Jenkins? Khronos is not using fl4re Jenkins, fl4re is donating Jenkins time and maintenance to openCOLLADA.

I cannot access fl4re jenkins system is used for internal project so its private.

** I would like to take a look at the logs, to figure out what my patch broke.**

 C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\functional(125): error C2220: warning treated as error - no 'object' file generated (compiling source file E:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\DAEValidator\library\src\XmlNode.cpp) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\build_win32\DAEValidator\DAEValidatorLibrary.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\functional(125): error C2220: warning treated as error - no 'object' file generated (compiling source file E:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\DAEValidator\library\src\DaeValidator.cpp) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\build_win32\DAEValidator\DAEValidatorLibrary.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\functional(125): error C2220: warning treated as error - no 'object' file generated (compiling source file E:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\DAEValidator\library\src\Log.cpp) [e:\git\workspace\COLLADA-MAYA-PC-PULL-REQUEST\build_win32\DAEValidator\DAEValidatorLibrary.vcxproj]

please let me know where to send to full logs.

RemiArnaud avatar Jul 17 '18 18:07 RemiArnaud

FAILURE: exercise-opencollada-pull-request build #157

Pull Requests:

  • PR https://github.com/KhronosGroup/OpenCOLLADA/pull/581: Fix line endings OpenCOLLADA

Fl4reBot avatar Oct 10 '18 22:10 Fl4reBot