GLSL icon indicating copy to clipboard operation
GLSL copied to clipboard

Simplify grammar for identifier_list

Open gnl21 opened this issue 1 year ago • 2 comments

An identifier list was defined as one or more identifiers preceded by a comma, so an additional rule was needed for a single identifier. Change the identifier_list to be what would normally be expected, a comma-separated list of one or more identifiers, and remove the additional rule.

gnl21 avatar Sep 11 '24 15:09 gnl21

@dj2 this was my first grammar change that was not taken up. The grammar is full of things like this that I consider to be bizarre and unhelpful definitions of commonplace things.

gnl21 avatar Sep 11 '24 15:09 gnl21

Update to glslang to use the simpler grammar here: https://github.com/KhronosGroup/glslang/pull/3772

gnl21 avatar Oct 24 '24 12:10 gnl21