node-csvtojson icon indicating copy to clipboard operation
node-csvtojson copied to clipboard

'noheader: false' should be 'header: true' (Avoid double negatives)

Open soulofmischief opened this issue 5 years ago • 1 comments

It's best to avoid use of confusing double negatives when designing APIs.

I suggest phasing in the parameter 'header' in this major version and phasing out the parameter 'noheader' in the next.

https://refactoring.com/catalog/removeDoubleNegative.html

soulofmischief avatar Jul 10 '20 19:07 soulofmischief

true, double negation might be a issue, but the docs are quite clear IMHO https://github.com/Keyang/node-csvtojson#header-row

jfoclpf avatar Feb 10 '22 13:02 jfoclpf