Flexo icon indicating copy to clipboard operation
Flexo copied to clipboard

Style pollution from :not rules

Open enure opened this issue 8 years ago • 0 comments

https://github.com/KevinPy/Flexo/blob/master/flexo.css#L240 https://github.com/KevinPy/Flexo/blob/master/flexo.css#L289 https://github.com/KevinPy/Flexo/blob/master/flexo.css#L338

These three rules can cause style pollution because they can target non flexo elements.

I think an improvement would be to adjust the attribute selector to use the $ character, which would target elements that end in -s, -m, and -l.

More info here: https://css-tricks.com/attribute-selectors/

enure avatar Sep 13 '17 16:09 enure

The problem is that it is a disabled button and should not be that bold.

Another problem might be that this button is invisible if the custom model is not enabled and so this is a bit hidden. But this makes sense from a functional perspective. Not sure how to improve it because clicking on it and enabling the custom model might be counter-intuitive (?)

It's a pencil next to a text box,

I'm unsure why the icons you refer are better in this regard. The current icon could be also interpreted as a pencil next to a rectangle.

karussell avatar May 24 '23 12:05 karussell

The problem is that it is a disabled button and should not be that bold.

I would say that other elements also suffer from this problem, but to a lesser extent.

  • gear icon
  • add location
  • Options

grafik

Maybe you could find a different mechanic to mark enabled elements instead of using grey for disabled ones. You're already using a blue shade to highlight the active profile. Maybe you could alternate between black and a blue?

Changing the background color might also be a valid approach to increase contrast.

Note that I have good eyesight, so this is a minor inconvenience for me. However, visually impaired users may not be able to fully use the interface.

Another problem might be that this button is invisible if the custom model is not enabled and so this is a bit hidden. But this makes sense from a functional perspective. Not sure how to improve it because clicking on it and enabling the custom model might be counter-intuitive (?)

I wouldn't change that to be honest.

I'm unsure why the icons you refer are better in this regard. The current icon could be also interpreted as a pencil next to a rectangle.

The current icon is the widely used for text editors and text input boxes:

grafik

That's why i would rather use something like this instead:

grafik

https://fontawesome.com/icons/draw-polygon?f=classic&s=regular

otbutz avatar May 24 '23 12:05 otbutz