key icon indicating copy to clipboard operation
key copied to clipboard

Extract Taclets and Prover Main Loop to ncore

Open Drodt opened this issue 10 months ago • 2 comments

Intended Change

This pull request is part of the modularization effort in KeY. It contains the first building blocks for generalizing the prover infrastructure, this includes the sequent data structure, as well as proof object, goal, rule, and the prover main loop.

Type of pull request

  • Refactoring (behaviour should not change or only minimally change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

Drodt avatar Mar 05 '25 10:03 Drodt

I put 42297e28e1af9e1520d8cfb545e63c0836f4f137 into the #3581.

You might want to drop this commit and rebase this PR.

wadoon avatar Mar 12 '25 19:03 wadoon

Codecov Report

Attention: Patch coverage is 37.52244% with 348 lines in your changes missing coverage. Please review.

Project coverage is 39.07%. Comparing base (9bf530f) to head (e4ce5c3). Report is 144 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/de/uka/ilkd/key/java/KeYJavaASTFactory.java 19.04% 68 Missing :warning:
...in/java/de/uka/ilkd/key/java/KeYProgModelInfo.java 32.35% 21 Missing and 2 partials :warning:
.../de/uka/ilkd/key/control/AbstractProofControl.java 0.00% 16 Missing :warning:
...c/main/java/de/uka/ilkd/key/logic/TermBuilder.java 56.75% 16 Missing :warning:
...main/java/de/uka/ilkd/key/macros/TestGenMacro.java 0.00% 12 Missing :warning:
...ava/de/uka/ilkd/key/java/Recoder2KeYConverter.java 66.66% 11 Missing and 1 partial :warning:
...ava/de/uka/ilkd/key/testgen/TestCaseGenerator.java 0.00% 9 Missing :warning:
...informationflow/rule/InfFlowContractAppTaclet.java 0.00% 9 Missing :warning:
.../uka/ilkd/key/java/recoderext/URLDataLocation.java 10.00% 9 Missing :warning:
...ontrol/instantiation_model/TacletAssumesModel.java 0.00% 8 Missing :warning:
... and 73 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3578      +/-   ##
============================================
- Coverage     39.58%   39.07%   -0.52%     
+ Complexity    17776    17164     -612     
============================================
  Files          2103     2016      -87     
  Lines        127775   126427    -1348     
  Branches      21500    21329     -171     
============================================
- Hits          50584    49402    -1182     
+ Misses        70998    70938      -60     
+ Partials       6193     6087     -106     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 11 '25 12:04 codecov[bot]