multired icon indicating copy to clipboard operation
multired copied to clipboard

[multired.py] Bug in "compute_JSD_matrix"

Open Sci-Robot opened this issue 6 years ago • 0 comments

Hi @KatolaZ,

Firstly, thank you so much for releasing the source code of your excellent work. It's really useful and enlightening.

Describe the bug While useing these scripts on my data, I got Jensen–Shannon distance bigger than 1, which woundn't be possible. So I went through the paper and code. Then I found the script multired.py line 283 to 286 inconsistent with the definition within subsection Jensen–Shannon distance between graphs, Structural reducibility of multilayer networks . I guess the comment line 281 and line 282 were the original code.

Also, the Von Neumann entropy is calculated using log base 2 in the papre, then the script multired.py line 163 uses base e.

Sci-Robot avatar Dec 20 '19 08:12 Sci-Robot