METIS icon indicating copy to clipboard operation
METIS copied to clipboard

Project modernization

Open LecrisUT opened this issue 2 years ago • 5 comments

Coming in are a bunch of project modernization. I will make a summary of all of the changes later on. Requires an equivalent change in GKlib, coming soon

Pinging @shengjianda as they initiated this movement

Closes #10, #18

Depends on: https://github.com/KarypisLab/GKlib/pull/33

LecrisUT avatar Oct 26 '23 15:10 LecrisUT

I don't want to sound overly pessimistic, but what gives you the confidence that Prof. Karypis will merge your code? There are trivial pull requests waiting for months to get any feedback. Also simple things like creating a tag for GKlib to create initial packages are not happening.
Maybe wait until you get some reactions or things merged, before you invest too much time.

gruenich avatar Oct 26 '23 21:10 gruenich

I don't want to sound overly pessimistic, but what gives you the confidence that Prof. Karypis will merge your code? There are trivial pull requests waiting for months to get any feedback.

This is due to the octopus project being keen on using METIS as a hard-dependency. I need to make these cahnges to be able to import it there anyway so I will be maintaining my fork that other people can use as well. This MR will be here for when Prof. Karypis wishes to make these changes official.

LecrisUT avatar Oct 26 '23 21:10 LecrisUT

@gruenich If you find it useful feel free to give it a try. Right now the project is importable, and I will test on octopus if it is usable in this form. The tests I couldn't get them to work properly, but with some feedback we can see this through.

LecrisUT avatar Oct 27 '23 15:10 LecrisUT

Is this repo still actively maintained by Prof. Karypis? Hope this PR will be merged soon.

adam-sim-dev avatar Nov 30 '23 13:11 adam-sim-dev

Is this repo still actively maintained by Prof. Karypis? Hope this PR will be merged soon.

adam-sim-dev avatar Nov 30 '23 13:11 adam-sim-dev