VaMPy icon indicating copy to clipboard operation
VaMPy copied to clipboard

A potential bug for determining time steps to be sampled

Open keiyamamo opened this issue 2 years ago • 0 comments

Hi @hkjeldsberg

If I understand correctly, save_frequency is the time step frequency used during the simulation, while step is how often you want to save the outputs.

https://github.com/KVSlab/VaMPy/blob/6c6468a4d8fcda89c330c9b01cea253e1bd3c8c3/src/vampy/automatedPostprocessing/compute_flow_and_simulation_metrics.py#L44

Here, saved_time_steps_per_cycle is divided by both save_frequency and step, but shouldn’t it be only save_frequency?

keiyamamo avatar Feb 23 '24 12:02 keiyamamo