kilt-node icon indicating copy to clipboard operation
kilt-node copied to clipboard

docs: Document safe use of Twox64Concat

Open weichweich opened this issue 2 years ago • 4 comments

fixes https://github.com/KILTprotocol/ticket/issues/2529

Metadata Diff to Develop Branch

Peregrine Diff
!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
No change detected
SUMMARY:
- Compatible.......................: true
- Require transaction_version bump.: false

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
Spiritnet Diff
!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
No change detected
SUMMARY:
- Compatible.......................: true
- Require transaction_version bump.: false

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!

Checklist:

  • [ ] I have verified that the code works
    • [ ] No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • [ ] I have verified that the code is easy to understand
    • [ ] If not, I have left a well-balanced amount of inline comments
  • [ ] I have left the code in a better state
  • [ ] I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

weichweich avatar Jan 12 '24 09:01 weichweich

  • [ ] check Metadata and SDK compatibility before merging

weichweich avatar Jan 30 '24 10:01 weichweich

This will break cross-chain DIP proofs since the storage keys (and the related proofs) have changed, hence we might want to change at least the DIP stuff to make it resistant.

ntn-x2 avatar Mar 06 '24 15:03 ntn-x2

DIP stuff was fixed in https://github.com/KILTprotocol/kilt-node/pull/613.

ntn-x2 avatar May 20 '24 10:05 ntn-x2

I'm putting this on hold until we get to a polkadot-sdk version that supports multi-block-migrations, after which we can revise this PR and perform the necessary migrations.

ntn-x2 avatar May 22 '24 08:05 ntn-x2