Charm icon indicating copy to clipboard operation
Charm copied to clipboard
verified publisher icon KDAB

1.12 makes KDAB internals mandatory

Open adriaandegroot opened this issue 7 years ago • 2 comments

In 1.11, it was possible to build without QtKeyChain, and then all the KDAB internals -- your in-jokes about lotsofcake, Bill, as well as the dependency on QtKeyChain and all the HTTP and REST-API support code -- would be left out. In 1.12 this dependency is required (in CMake) and all the support for optional cake has been removed; none of it is visible to the user without the undocumented KDAB-internal configuration settings, but it's weirdly annoying to pull in such unused dependencies.

adriaandegroot avatar Sep 01 '18 18:09 adriaandegroot

These features (i.e. timesheet reminder etc.) should only be enabled on the UI level once someone imported project codes from KDAB's server, need to investigate why they are suddenly enabled for everyone.

frankosterfeld avatar Sep 03 '18 06:09 frankosterfeld

Sorry, I should have phrased that better:

  • the features are not enabled at the UI level
  • the supporting code is enabled, which is kind of annoying because of the extra dependencies The previous version left out all the supporting code (and the UI) when qtkeychain wasn't found.

adriaandegroot avatar Sep 03 '18 07:09 adriaandegroot