Sagar Paul
Sagar Paul
@jorgenspange The behavior in cisco.ios is wrong. We would push a patch to fix it. The facts are not rendering `user-> authentication -> password` information in snmp_server Playbook - ```...
CC @roverflow This would need fix in cisco.ios ^ Regards
@eleksis Thank you for working on it the fix looks good to me, can you please add a changelog describing the fix and a test (unit) for the same? Let...
The command patterns are added as comments, to save some time during development. Would be removed before we merge it!
Closing it off, as the issue is already fixed in https://github.com/ansible/ansible/pull/78236 Regards
Hey @bentole would you please add integration tests to this PR. I am testing it on my end and will get back to you. Regards
@bentole the changes look good, I made some cosmetic changes to the tests. We cannot have commit_delay as an attribute, I totally get the idea behind the delay as (time.sleep)...
hey @bentole, I understand the _implicit_ and _explicit_ commit and you rightly pointed out the challenges that may come with that. And we have been through this discussion internally for...
Hey, @bentole I have pushed changes as per our discussion to this PR itself. Let me know if you have any concerns about any of the changes. Regards.
Heyy! @bentole I stopped and thought long before taking out that chunk of exception handling. Few things that convinced me to take it out. 1. command timeout can be triggered...